Notable changes are:
* Refactored views, utilizing more of Djangos features, resulting in simpler
code.
* URLs are now the same when initially filling out a form and when editing a
submitted form which contained errors.
* Instead of a result page showing the response from the DNS server (which is
now logged using Djangos "logging" functionality) the user is now redirected
back to the record listing of the current zone when the action was successful
or stays on the form page when an error occured. Proper success/error
messages are shown in both cases by utilizing Djangos "messages"
functionality.
Changes are:
* Display invalid input in editable input fields instead of adding it to the
end of the error message. This should improve user experience in case of
typos etc. where they now can simply edit there previously entered value.
* Use a single variable for form data and form errors, instead of using two.
Makes the code a bit cleaner.
This commit changes the layout of binder to provide a better experience on
mobile devices and for form validation errors. It's outcome might not be
perfect yet, but I believe it's a really nice step forward.
The changes consist of:
* moving the menu from the left side to the top, so it doesn't consume
additional screen space when scrolling down
* changed the width of the content to depend on the screen size. For larger
screens the forms won't consume the whole width, but validation errors will
be shown beside the form field containing the error
* showing field independent error messages on top of each form
* highlighting of form fields which contain errors
The tests checking the DNS resolution aren't reliable as they rely on specific
behavior of the DNS resolution on the local system. As they are reliable it
makes no sense to keep them as they are currently.
resolve some conflicts with templates
Conflicts:
binder/templates/bcommon/add_cname_record_form.html
binder/templates/bcommon/delete_record_initial.html
This commit adds global authentication to binder to ensure that only valid
users are able to use it. This should enable binder to be used in
environemts where it's webfrontend is reachable for unauthenticated users as
well.
For setups where such a global authentication isn't desired it can be disabled
by simply removing the LoginRequiredMiddleware from the list of active
middlewares.
Up to now local_settings.py was used for binder specific configuration values.
This commit moves these values to settings.py, removes local_settings.py
from version control and adds logic to settings.py to allow settings in
local_settings.py to overwrite ones defined in settings.py, enabling
local_settings.py to be used as installation specific configuration file,
e.g. for custom database configuration.
* Replaced tabs for indentation with proper spaces to have only spaces for
indentation
* Added the btn-default class to all buttons where it was missing
* Added relations between labels and the elements they are labeling using the
naming schema Django uses by default (might become handy in the future)
* Added additional meta tags required by Bootstrap 3
* Moved the button for adding records in list_zone.html out of the table to get
cleaner markup
* Swapped out the used version of Bootstrap against the minified one.
* Removed the commented out old code from delete_record_initial.html, because
that's why we have version control
Daniel Roschka
jeffrey forman
Jeffrey Forman