* Replaced tabs for indentation with proper spaces to have only spaces for
indentation
* Added the btn-default class to all buttons where it was missing
* Added relations between labels and the elements they are labeling using the
naming schema Django uses by default (might become handy in the future)
* Added additional meta tags required by Bootstrap 3
* Moved the button for adding records in list_zone.html out of the table to get
cleaner markup
* Swapped out the used version of Bootstrap against the minified one.
* Removed the commented out old code from delete_record_initial.html, because
that's why we have version control
Up to now jQuery has been the only resource required by binder which users had
to load from the internet. To enable binder to work in environments where no
internet access is available this commit adds jQuery 2.1.3 to binders static
files so no internet access is necessary anymore for using binder.
To improve the code quality of binder, this commit adds support for continuous
integration by using Travis CI (https://travis-ci.org/).
This will ensure that every commit and every pull request will trigger test
runs of the tests included in binder, helping to avoid code with broken tests.
Fixes three failing tests.
For test_ipinfo_ResolutionFail it fixes the following issues:
* failing when no network is available
* failing when Google changes the ip addresses of the service
* failing when the order of returned ip addresses is different
For test_DeleteRecordInitial_Empty and test_DeleteRecordInitial it fixes a not
existing BindServer object.
When requesting one of binders BIND server specific URLs for a server not
present in binders database currently uncatched exceptions are thrown.
This commit fixes that for all URLs containing the server name, by instead of
throwing an uncatched exception, returning a proper HTTP 404 status code.
While it might not be that common to have a DNS server listening on a
non-standard port for DNS queries, it's also useful for local testing.
I used the opportunity to add model migrations as well to enable smooth model
upgrades.
When using Djangos "makemessages" command to collect strings for i18n it only
considers templates with a file extenions of .txt and .html by default. For
more details see:
https://docs.djangoproject.com/en/dev/topics/i18n/translation/#message-files
Also when Django is refering to default template names (e.g. for error handling
or accounts) it always refers to file names with .html as file extension.
To avoid hassle in the future this commit aligns the file extension used for
templates to Djangos default of .html.
are fixed in this commit:
* Cancel links were converted to buttons, by simply wrapping them into a
<button>-element, causing them to act as submit buttons, as submit is the
default action for buttons, instead of cancel buttons. Instead the proper
bootstrap code for showing links as buttons is used now.
* add_cname_record_form.htm hasn't been adjusted to show a button instead of a
link for cancelling. I converted that to a button now as well.
To quote from Djangos documentation:
"The secret key must be a large random value and it must be kept secret."
https://docs.djangoproject.com/en/1.7/howto/deployment/checklist/#secret-key
This commit achieves that by generating a file containing a random string
when running the first time and by using this string as SECRET_KEY from then
on.
This commit introduces automatic selection of the default TSIG key for all
available actions (add, delete). For enabling that it has been necessary to
provide the whole BindServer object to the template, which caused some
additional changes.
I also took the opportunity to unify some styling (indentation, linebreaks) of
the HTML templates.
binder has been broken to work with signatures created with anything but
dnspythons default TSIG algorithm, which currently is HMAC-MD5.
This commit fixes that by properly using the algorithm stored for the key.
The error handling for broken TSIG keys wasn't working for two reasons:
* the import of binascii has been missing, producing a NameError once an
exception occured
* The exception handler was refering to a non-existant variable key_name.
This commit fixes both issues.
* Added help texts to all fields to make adding servers and keys in the admin
interface more convenient.
* Added a default ordering for servers and keys.
* Added unique constraints, so there can be only on key per name and one server
per hostname as this has already already been an implicit constraint in the
code.
Daniel Roschka
jeffrey forman
Jeffrey Forman
Jeffrey Forman